-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #6058 Dropdown: Select value with Enter when optionValue is set #6703
Conversation
- When pasted the value into InputOtp, was duplicating the value, as the state was updated in onPaste and onInput
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
This comment was marked as outdated.
This comment was marked as outdated.
This is quite a breaking change, when setting optionValue, normally you get a prop of an item object back in the onChange, now you always get the entire item. also setting the value using this optionValue is no longer working |
@matthijsgroen i think its already fixed for 10.7.1: https://github.com/primefaces/primereact/issues?q=is%3Aclosed+milestone%3A10.7.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This created another issue when "optionValue" is provided. In this case, it started returning whole object instead of just a value of specific field provided in optionValue.
@melloware Yes, this is true. It created another bug. My entire app broke. Please help, as Dropdown is a very important component. |
OK all I reverted it here: #6885 |
I don't understand what I should do so that enter in my dropdown now works together with the inputValue property
|
Fix #6058
When optionValue was set, and try to select the value with
Enter
key, the value is not selected.In my correction, I saw that the
selectItem
function already has thegetOptionValue
function, making it unnecessary to call it within theonOptionSelect
function.